Revert "Link LLVM dynamically on aarch64-apple-darwin" and "re-enable enzyme/autodiff builds on dist-aarch64-apple" by ZuseZ4 · Pull Request #154485 · rust-lang/rust

ZuseZ4 · 2026-03-27T23:59:29Z

This reverts commit e7c268f.

This approach was much better than the last time, as it didn't break downstream users like miri.
Unfortunately, it still broke rustc contributors and is blocking some people: #154408
The previously discussed solution (symlink) didn't seem to work for a user, and shipping two full copies of LLVM (old + new name) until the next stage0 compiler bump should probably be discussed first. We now also have artifacts of a nightly or two, which can be used for local experimenting, so hopefully next time we won't break anyone at all.

cc @sgasho

r? @jieyouxu

jieyouxu

Can you force a CI LLVM stamp bump here too?

View changes since this review

rustbot · 2026-03-28T02:30:12Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jieyouxu

Thanks!

View changes since this review

jieyouxu · 2026-03-28T02:34:11Z

@bors r+ p=10 rollup=never (unblock bootstrap on macos)

rust-bors · 2026-03-28T02:34:14Z

📌 Commit 0ae31c4 has been approved by jieyouxu

It is now in the queue for this repository.

@sgasho

…ieyouxu Revert "Link LLVM dynamically on aarch64-apple-darwin" This reverts commit e7c268f. This approach was much better than the last time, as it didn't break downstream users like miri. Unfortunately, it still broke rustc contributors and is blocking some people: #154408 The previously discussed solution (symlink) didn't seem to work for a user, and shipping two full copies of LLVM (old + new name) until the next stage0 compiler bump should probably be discussed first. We now also have artifacts of a nightly or two, which can be used for local experimenting, so hopefully next time we won't break anyone at all. cc @sgasho r? @jieyouxu

This reverts commit 988633d.

This reverts commit e7c268f.

rust-bors · 2026-03-28T04:19:45Z

⚠️ A new commit 0d3d1ac9b3417fcea4fc2cb631779b32891c14d0 was pushed.

This pull request was unapproved.

Auto build was cancelled due to push. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/23676173322

jieyouxu

Thanks, yeah I thought that was already disabled.

@bors r+

View changes since this review

rust-bors · 2026-03-28T04:22:01Z

📌 Commit 0d3d1ac has been approved by jieyouxu

It is now in the queue for this repository.

rust-bors · 2026-03-28T07:35:13Z

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 8m 15s
Pushing c4db0e1 to main...

github-actions · 2026-03-28T07:38:41Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e161368 (parent) -> c4db0e1 (this PR)

Test differences

Show 1 test diff

Stage 2

[run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J0)

Job group index

J0: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c4db0e127c6e96d1798423bf9f205fd06f5481a6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-tools: 52m 17s -> 1h 15m (+45.2%)
pr-check-1: 28m 14s -> 40m 19s (+42.8%)
x86_64-rust-for-linux: 44m 59s -> 1h 3m (+40.2%)
pr-check-2: 38m 25s -> 51m 31s (+34.1%)
x86_64-gnu-nopt: 2h 10m -> 2h 46m (+27.4%)
test-various: 1h 53m -> 2h 23m (+26.5%)
x86_64-gnu-gcc: 1h 3m -> 1h 19m (+25.3%)
arm-android: 1h 36m -> 2h 1m (+24.9%)
armhf-gnu: 1h 23m -> 1h 43m (+24.3%)
optional-x86_64-gnu-parallel-frontend: 2h 10m -> 2h 40m (+22.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-28T08:16:51Z

Finished benchmarking commit (c4db0e1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 13.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	13.0%	[13.0%, 13.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	13.0%	[13.0%, 13.0%]	1

Cycles

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.178s -> 485.299s (0.23%)
Artifact size: 395.05 MiB -> 395.08 MiB (0.01%)

`rustc-llvm-proxy` used to work on musl targets by accident because `LD_LIBRARY_PATH` let it `dlopen` our shared LLVM library. After switching to `rpath`, that no longer works: our shared LLVM library is not visible to `rustc-llvm-proxy`, and musl Rust toolchains ship `libLLVM` statically, so there is no shared library for `rustc-llvm-proxy` to load. This caused CI failures such as: unable to read dir /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib: No such file or directory (os error 2) thread 'test_link_ir_files' (4) panicked at /rustc/cf7da0b7277cad05b79f91b60c290aa08a17a6f0/library/core/src/panicking.rs:225:5: [...] unable to read dir /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib: No such file or directory (os error 2) unable to read dir /root/.cargo/lib: No such file or directory (os error 2) thread 'test_link_ir_files' (4) panicked at /home/runner/work/bpf-linker/bpf-linker/bpf-linker/target/x86_64-unknown-linux-musl/debug/build/aya-rustc-llvm-proxy-5f163ea45ef44b54/out/llvm_gen.rs:14919:10: LLVMParseIRInContext2: DlSym { source: "Symbol not found: LLVMParseIRInContext2" } The behavior on darwin targets is not reliable. Stable Rust toolchains for macOS link `libLLVM` statically. Nightly tried to switch to dynamic linking[0][1], but those attempts were reverted twice[2][3]. Prevent any related issues by excluding `default` and `rust-llvm-*` features on darwin and musl targets. [0] rust-lang/rust#152768 [1] rust-lang/rust#151063 [2] rust-lang/rust#153079 [3] rust-lang/rust#154485

rustbot assigned jieyouxu Mar 27, 2026

ZuseZ4 mentioned this pull request Mar 28, 2026

core: Destabilize beta-stable RangeInclusiveIter::remainder #154459

Merged

jieyouxu reviewed Mar 28, 2026

View reviewed changes

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 28, 2026

ZuseZ4 force-pushed the revert-aarch64-apple-dynamic-llvm branch from b03112a to 0ae31c4 Compare March 28, 2026 02:30

jieyouxu approved these changes Mar 28, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026

This comment has been minimized.

Sign in to view

ZuseZ4 added 3 commits March 28, 2026 05:11

Revert "re-enable enzyme/autodiff builds on dist-aarch64-apple"

41c932c

This reverts commit 988633d.

Revert "Link LLVM dynamically on aarch64-apple-darwin"

a3261a2

This reverts commit e7c268f.

bootstrap: force a CI LLVM stamp bump

0d3d1ac

ZuseZ4 force-pushed the revert-aarch64-apple-dynamic-llvm branch from 0ae31c4 to 0d3d1ac Compare March 28, 2026 04:19

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026

jieyouxu changed the title ~~Revert "Link LLVM dynamically on aarch64-apple-darwin"~~ Revert "Link LLVM dynamically on aarch64-apple-darwin" and "re-enable enzyme/autodiff builds on dist-aarch64-apple" Mar 28, 2026

jieyouxu approved these changes Mar 28, 2026

View reviewed changes

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 28, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 28, 2026

jieyouxu mentioned this pull request Mar 28, 2026

Rollup of 9 pull requests #154489

Merged

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026

rust-bors bot merged commit c4db0e1 into rust-lang:main Mar 28, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 28, 2026

lqd mentioned this pull request Mar 28, 2026

./x build failed with llvm-config: error: libLLVM-22-rust-1.96.0-nightly.dylib is missing #154408

Closed

Uh oh!

Conversation

ZuseZ4 commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Mar 28, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Mar 28, 2026

Uh oh!

rust-bors bot commented Mar 28, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 28, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Mar 28, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 28, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2026

Test differences

Stage 2

Job duration changes

Uh oh!

rust-timer commented Mar 28, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZuseZ4 commented Mar 27, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading